search

frondeus / fvtt-syrin-control

Syrinscape Online Control plugin for FoundryVTT
MIT License
13 stars 4 forks source link

Incompatibility with Monks Sound Enhancements #95

Closed frondeus closed 1 year ago

frondeus commented 1 year ago

That fixed it, thanks!

I have one request, if possible. It looks like the new UI improvement isn't compatible with the module Monk's Sound Enhancements. It's not completely broken. It's very minor, actually. That module adds tabs to the Edit Playlist box, and that pushes the rest of the content down, but the box doesn't resize to account for this. It also adds some additional options that go away when Syrincontrol is present. Here are some screenshots to demonstrate.

Only Syrincontrol: image

Only Monk's Sound Enhancements: image

Both modules: image

"No" is an acceptable answer for this one, but hopefully it's also an easy adjustment. :)

Originally posted by @notrealdan in https://github.com/frondeus/fvtt-syrin-control/issues/92#issuecomment-1500616691

frondeus commented 1 year ago

Sooo the solution would be to somehow hide what monks module added?

I can try to do so but perhaps it should be added in that module instead?

Every playlist, ambient sound etc have aen extra flag flags.syrinscape so my module can detect that it is something that needs it's control.

So minks module could detect it too and abort adding the tab.

notrealdan commented 1 year ago

Yes, I think having Monk's module ignore SyrinControl playlists would make the most sense. I opened an issue for this on their github here: https://github.com/ironmonk88/monks-sound-enhancements/issues/14

notrealdan commented 1 year ago

This was fixed in the latest version of Monk's module. This issue can be closed!