Make inconclusive a keyword - Githubissues

frondeus / test-case

Rust procedural macro attribute for adding test cases easily

MIT License

614 stars 39 forks source link

Make inconclusive a keyword #20

Closed frondeus closed 4 years ago

frondeus commented 5 years ago

/u/somebodddy noticed that inconclusive could be keyword, not a part of string.

Advantages:

With keyword approach typo could emit a compilation error, while typo in string creates just test case with no #[ignore] attribute.
It gives us extendable syntax, for example today its inconclusive, tommorow could be should_panic.

Disadvantages:

Breaking change for already written tests - tests with "inconclusive" string will loose theirs #[ignore] attribute (which may cause failed tests or false positives or even non deterministic CI behavior)
Keyword approach makes "inconclusive" in fixed position, while in string you can put in in the middle of sentence.

Feel free to comment :)

frondeus commented 4 years ago

With #21 i created panics and matches keywords. Maybe inconclusive is an option?

AD. 1st disadvantage - I could simply accept both inconclusive keyword and substring in description. I could also mark substring as deprecated.