search

frondeus / test-case

Rust procedural macro attribute for adding test cases easily
MIT License
614 stars 39 forks source link

Update snapshots to support should_panic behavior of including "- should panic" in test results. #68

Closed jgerrish closed 3 years ago

jgerrish commented 3 years ago

The should_panic attribute inserts "- should panic" into tests results. I've updated the expected test snapshots with this text so all tests should pass now.

Let me know if you have any change requests or a better solution.

Thank you and wonderful work with this crate. Both this and insta are being added to my Rust toolbox for future projects.

luke-biel commented 3 years ago

Hey, appreciate the PR :) I wasn't even aware of the logging changes.
I think this may mean that we need to change the way we test test-case, as this alone will break our 1.41 toolchain tests. Not the first time there's such discrepancy between versions, last time we just dropped older toolchain version tests, but I don't think this is a solution now.

I need to think of a way to approach this.

jgerrish commented 3 years ago

Thanks for the response. My fault, I didn't run the full CI pipeline including windows-latest with 1.41.0.

Next time I make a fix somewhere I'll try to run any appropriate GitHub actions or CI before opening a pull request. Thanks again! Feel free to close or I can.

luke-biel commented 3 years ago

I'm gonna close this for now. I have to prepare test suite per rust version probably, to make this work.