search

frontarm / create-universal-react-app

Configuration-free SSR for Create React App.
MIT License
126 stars 1 forks source link

CRA 3.3.0 #6

Open DB-Alex opened 4 years ago

DB-Alex commented 4 years ago

Hi @jamesknelson ,

When do you expect to bump CURA to 3.3.0?

https://github.com/facebook/create-react-app/releases/tag/v3.3.0

jamesknelson commented 4 years ago

I plan on having a look this weekend, but not sure if I'll get it finished. The thing about 3.3.0 is that it adds template support, and CURA is basically a custom template, so it's a much much bigger change than the previous release.

I think what needs to happen is that the create-universal-react-app script itself can be dropped, and the whole thing can be set up as two new CRA templates (SSR JS and SSR TS). These templates can then replace react-scripts with universal-react-scripts.

If you'd like to take a look, I'd certainly be happy to accept a PR ;)

DB-Alex commented 4 years ago

Maybe in time I can help you out with PRs of this kind, but for know I still need to learn a lot :)

Excited about the 3.3.0 release though ;)

gut4 commented 4 years ago

Any updates on this?

jamesknelson commented 4 years ago

I took a look at it and found that it's going to be a little unwieldy, as instead of just specifying a scripts-version, you'll now need to specify a matching template.

For now, I've created this issue on CRA to try and help resolve this: https://github.com/facebook/create-react-app/issues/8335. If there's no response soon though, I may just implement this the ugly way where you need to specify a separate template.