Bug with styles not being passed to Link.

frontarm / navi

🧭 Declarative, asynchronous routing for React.

https://frontarm.com/navi/

MIT License

2.07k stars 71 forks source link

Bug with styles not being passed to Link. #184

Closed izakfilmalter closed 4 years ago

izakfilmalter commented 4 years ago

I believe there is a bug with Link and how it deals with the style prop. I ran into this while using the Link in a react-window container. Scrolling wasn't working because style was not getting passed to the element. Dug into the Link code and found the bug here:

        style={
          style && activeStyle
            ? Object.assign({}, style, active ? activeStyle : {})
            : undefined
        }

My temp solution was to pass an empty object to activeStyle.

izakfilmalter commented 4 years ago

Opened PR to resolve.