One off import from the old timetable system

[simong]

Allows you to:

1. Dump data from the old timetable system
2. Massage it into a format that can be ingested (and manually manipulate it if you want to) Also takes care of rolling over dates
3. Import it into an application in Grasshopper

[coveralls]

Coverage decreased (-0.25%) to 90.08% when pulling 2c053d3279e0a86525276abce718118366a4e3a9 on oneoff-old-timetable-import into 31bb4fed740cb28d60e35b149dccdf2de5bb8ac1 on master.

[coveralls]

Coverage decreased (-0.25%) to 90.08% when pulling 2c053d3279e0a86525276abce718118366a4e3a9 on oneoff-old-timetable-import into 31bb4fed740cb28d60e35b149dccdf2de5bb8ac1 on master.

[simong]

That .25% decrease in coverage is because all the pattern logic has been moved to the etc/scripts/.. folder and isn't covered during testing

[simong]

Note that this doesn't have the organisers yet

[nicolaasmatthijs]

@simong : Is this ready for review yet? If so, I think it would be useful if @mrvisser could do a first pass at reviewing this, perhaps with some guidance from yourself. I'd be happy to do a second pass on this.

[simong]

I think so, we can do the organisators at a later stage.

[nicolaasmatthijs]

Assigning to @mrvisser for first round of review.

[simong]

Disregard that, I'm going to try and add locations and maybe users anyway

[coveralls]

Coverage decreased (-0.4%) to 89.93% when pulling ab82c0d0fbc3e8ed579f52521023e90dc48ccc91 on oneoff-old-timetable-import into 31bb4fed740cb28d60e35b149dccdf2de5bb8ac1 on master.

[coveralls]

Coverage decreased (-0.4%) to 89.93% when pulling e7c8e759e3693b3d4077931b4f4b3b86f4e0face on oneoff-old-timetable-import into 31bb4fed740cb28d60e35b149dccdf2de5bb8ac1 on master.

[simong]

This is ready for review as well

[coveralls]

Coverage decreased (-0.34%) to 91.14% when pulling 9ac7887a5d67135a25a6a55f2689abee44f5bcf7 on oneoff-old-timetable-import into 783521b14879fe270be1345e44995118f159130e on master.

[simong]

I did some more work on this so it includes the external URLs. This is ready for review

[simong]

This is now also required for the import endpoint

[coveralls]

Coverage decreased (-0.33%) to 91.15% when pulling f262e4cd303081e6c4bcc40130894c159acce523 on oneoff-old-timetable-import into 783521b14879fe270be1345e44995118f159130e on master.

[simong]

Considering we'll have an actual import endpoint soon, I might rewrite some of the logic to use the actual REST endpoint

[coveralls]

Coverage decreased (-0.32%) to 91.17% when pulling ce1272cbdb9d9056d1bb4c7ce875a69ec5d83bf4 on oneoff-old-timetable-import into 5ec550a2a608192db448f9324006ac3c8c655265 on master.

[simong]

This has been refactored to re-use the import API logic

[coveralls]

Coverage decreased (-0.5%) to 90.99% when pulling 92ab6ba700383556925618ec369c1d6e36d72d7a on oneoff-old-timetable-import into 5ec550a2a608192db448f9324006ac3c8c655265 on master.

[coveralls]

Coverage decreased (-0.51%) to 90.98% when pulling fcc96149519b8a4bd3548a3ac4cd06f29aed1ac6 on oneoff-old-timetable-import into 5ec550a2a608192db448f9324006ac3c8c655265 on master.

[simong]

I've rebased this branch against master, this is ready for review. It looks worse than it is, most of it is just scripts calling the API, django commands and some cleanup

[coveralls]

Coverage decreased (-0.13%) to 90.71% when pulling 364740450791f13d1aa7a010b2ec9127f715c0a6 on oneoff-old-timetable-import into 88d83dfcb948fd42ae4d1f8be474c716a20f2d38 on master.

[mrvisser]

Just a few questions, but I can't spot any issues with this. Assigning back to @simong for followup, and maybe it would be good to have @nicolaasmatthijs give a round as well assuming, he has worked with the legacy side of the data-model a bit more.

[simong]

I don't think I have anything else to do here, back to @mrvisser

[coveralls]

Changes Unknown when pulling 221ed8bee58ec8ba01d0b0fffeb176ec8fc464a1 on oneoff-old-timetable-import into \ on master**.

[mrvisser]

Followed up and merged