Implemented the import users endpoint

fronteerio / grasshopper

Grasshopper Event Engine

GNU Affero General Public License v3.0

3 stars 12 forks source link

Implemented the import users endpoint #86

Closed simong closed 9 years ago

simong commented 9 years ago

This allows a global administrator to upload a CSV file and import a set of users. The request parameters AND csv file will be validated prior to actual user creation/updating. The actual creation/updating happens async from the request.

This also brings in busboy as the new HTTP body parser

coveralls commented 9 years ago

Coverage increased (+0.07%) to 90.4% when pulling 89a5a9c7e5a777f1516d1de54844d6928db3d321 on users-import into eafeb1e7a444ab70feb1762309a601710b1c4f60 on master.

mrvisser commented 9 years ago

Looks really good overall, back to @simong for some followup.

coveralls commented 9 years ago

Coverage increased (+0.07%) to 90.4% when pulling 67adf859e6d2a64da504d2f8cc3d407c09529b9e on users-import into eafeb1e7a444ab70feb1762309a601710b1c4f60 on master.

coveralls commented 9 years ago

Coverage increased (+0.09%) to 90.41% when pulling e40ede9bde94cb212da27108007b9f2cadc14612 on users-import into eafeb1e7a444ab70feb1762309a601710b1c4f60 on master.

simong commented 9 years ago

Followed-up on review, back to @mrvisser

mrvisser commented 9 years ago

I've added some more comments, back to @simong for followup.

simong commented 9 years ago

Pushed follow-up, back to @mrvisser

coveralls commented 9 years ago

Coverage increased (+0.06%) to 91.48% when pulling c5b7fa5206b5f87d662d4307b8ee5ab2767668e1 on users-import into b1d31fc1aec6c1e42dc289fb9cda6862c099696d on master.

mrvisser commented 9 years ago

:+1: !