search

fronteers / website

New website for Fronteers
https://www.fronteers.nl
MIT License
16 stars 17 forks source link

Update members-list.json #335

Closed banaan666 closed 8 months ago

edwinm commented 8 months ago

A formatted JSON is really preferred.

SleeplessByte commented 8 months ago

@edwinm then why was this merged 😆 ?

banaan666 commented 8 months ago

Because this is how we currently update the memberlist, it was never formatted before. Also I don't have the time and energy currently to look into adding formatting to the JSON I export from the membership administration.

SleeplessByte commented 8 months ago

https://github.com/fronteers/website/pull/334#issue-2133075237, thus prettier -w . or prettier -w src/_data/members-list.json

If you want a GitHub Action to automatically format it when you PR an update, I can write that, if that solves the issue. Without the formatted file structure there is no good way to see changes (and thus it's hard to detect issues with the file, the output, or contents as well).

banaan666 commented 8 months ago

That would be really helpful Derk-Jan if you could implement this on the Github side of things.

SleeplessByte commented 8 months ago

I'll add it to my list!