frontendnetwork / veganify

Veganify is a modern webapp that allows you to easily scan EAN barcodes to check if a product is vegan-friendly. With a database of over 3 million products, you can quickly find out if your favorite foods and products are suitable for a vegan diet.
https://veganify.app
MIT License
43 stars 6 forks source link

PWA status: Lighthouse could not determine if there was a service worker. #44

Closed philipbrembeck closed 2 years ago

philipbrembeck commented 2 years ago

Lighthouse does not find the serviceworker anymore (although it is recognized by chrome canary) and therefore displays no install promt on android devices anymore.

philipbrembeck commented 2 years ago

Seems to be a problem in Canary Lighthouse: #13396

'sw.js' and initalizer work as expected - iOS is not affected from install popup not working.

gitgauner commented 2 years ago

I've encountered a few bugs while using Lambdatest (Google Pixel 4A, Android 11.0). It seems to be that no "Install app"-prompt is displayed on android phones at all (tested with several real devices). Afaik this was a thing before, wasn't it? Installing as an app works fine.

Quick video: image

philipbrembeck commented 2 years ago

https://github.com/GoogleChrome/lighthouse/issues/13138

gitgauner commented 2 years ago

The fix was apparently merged and released, although the above mentioned issues are not closed atm.

Lighthouse however throws no errors anymore, and the Install app prompt is available again:

Bildschirmfoto 2021-12-19 um 15 38 42

Tested with Chrome on Google Pixel 4A, Android 11.0. Firefox testing will follow and I'll reopen the issue if anything does not work correctly.

Until then: Fixed.