search

frontendstudygroup / frontendstudygroup.github.io

Web application for the frontend study group from WomenWhoCode Frontend track.
https://frontendstudygroup.github.io/
17 stars 17 forks source link

Add GitHub Action to deploy to GitHub pages #22

Closed sunithapatel closed 3 years ago

sunithapatel commented 3 years ago

This GitHub action does build, run tests and deploy to GitHub pages only if the branch is master. It will run the first two steps for pull requests.

Closes #19.

princiya commented 3 years ago

neat 💯 @sunithapatel

sunithapatel commented 3 years ago

FYI: I see that there are some errors to clean up here to get the build to work. I will take a look at these before we merge this PR as this will be used as a check for future PRs. I also want to test that it deploys correctly to GitHub Pages before merging this. Once this is done then we can merge this.

sunithapatel commented 3 years ago

Okay got it working. It looks like npm build treats warnings as errors which is why the build failed initially. Then the one test we had was wrong so I fixed that as well.

I commented out the condition for deploying to master to test out the GitHub pages deploy and that works too, so I put back the condition.

So now it is ready to merge. It just may cause some conflicts with other PRs since I had to change the links in the Header.js component but it should not be too bad.