#14 added router component

frontendstudygroup / frontendstudygroup.github.io

Web application for the frontend study group from WomenWhoCode Frontend track.

https://frontendstudygroup.github.io/

17 stars 17 forks source link

#14 added router component #23

Closed RossellaFer closed 3 years ago

RossellaFer commented 3 years ago

Added Router component using react-dom-router
Created Resources component with minimum JSX
Routes include / for App component and /resources for Resources component
added href for /resources to header

princiya commented 3 years ago

@sunithapatel I have approved this PR. let me know if you have further comments or feedback, if not we can merge this one.

princiya commented 3 years ago

@RossellaFer there is a merge conflict on Header.js, we merged another PR just now. Sorry about that, please resolve the conflicts when you get time, if you need help with resolving merge conflicts let us know, we can help you. :)

sunithapatel commented 3 years ago

@RossellaFer Sorry about this but when I set up GitHub actions to build and deploy the site, it treats warnings as errors. I had to change the urls in Header.js to resolve this. Now your changes will conflict with this. Can you choose all your changes when resolving the conflict and keep the /about and /contact for the other links? Otherwise the build will fail (I think we should pay attention to warnings and remove them anyway).

Please let me know if I can help you with this!

RossellaFer commented 3 years ago

That's great, I have made the changes to the links so it should be ready to be merged

sunithapatel commented 3 years ago

Yay thank you @RossellaFer! Awesome job!!! I approved it so once it is done with the build I will merge it and hopefully if the GitHub Action works and it will deploy the changes to the site.