frontendstudygroup / frontendstudygroup.github.io

Web application for the frontend study group from WomenWhoCode Frontend track.
https://frontendstudygroup.github.io/
17 stars 17 forks source link

Fixes #[28] Implement a Footer #32

Closed hunterachieng closed 3 years ago

hunterachieng commented 3 years ago

Created a Footer component that contains the social media links of the WWCode Front End group.

princiya commented 3 years ago

good attempt with the PR itself. try to work on the nit-fixes mentioned above, and you will applaud yourself for understanding CSS better. :) also, there seem to be merge conflicts, let us know if you cannot resolve them yourself and we will help you out.

hunterachieng commented 3 years ago

Thank you. I will look into the PR issues and learn more about flexbox as you suggested.

On Thu, 7 Oct 2021, 10:08 Princiya Marina Sequeira, < @.***> wrote:

good attempt with the PR itself. try to work on the nit-fixes mentioned above, and you will applaud yourself for understanding CSS better. :) also, there seem to be merge conflicts, let us know if you cannot resolve them yourself and we will help you out.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/frontendstudygroup/frontendstudygroup.github.io/pull/32#issuecomment-937515584, or unsubscribe https://github.com/notifications/unsubscribe-auth/AS4KQNSANF437OJ26Y4OLUDUFVBQBANCNFSM5FODRIXA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

princiya commented 3 years ago

@hunterachieng CSS is good to go 🚀 good job 👏 There is a merge conflict with src/components/Router.js. Can you please fix it?

hunterachieng commented 3 years ago

I have now fixed it.

princiya commented 3 years ago

thanks for the PR @hunterachieng good one!