Feature/card detail - Githubissues

frontendstudygroup / frontendstudygroup.github.io

Web application for the frontend study group from WomenWhoCode Frontend track.

https://frontendstudygroup.github.io/

17 stars 17 forks source link

Closed RossellaFer closed 3 years ago

RossellaFer commented 3 years ago

princiya commented 3 years ago

another good PR @RossellaFer , thank you. just some nit fixes based on the above comments, otherwise this is great work.

sunithapatel commented 3 years ago

Yup definitely agree with @princiya! Great work @RossellaFer!!!

RossellaFer commented 3 years ago

Thank you both for checking the PR! Made some adjustments (and caught a data id duplication in the data.json file)

Please let me know if there is anything else that needs to be changed (I missed code reviews :) )

princiya commented 3 years ago

good job @RossellaFer ❤️ 🎉