frontendstudygroup / frontendstudygroup.github.io

Web application for the frontend study group from WomenWhoCode Frontend track.
https://frontendstudygroup.github.io/
17 stars 17 forks source link

Toggle between Card/Table View #44

Closed Priyami closed 3 years ago

Priyami commented 3 years ago
sunithapatel commented 3 years ago

It looks like there are some warnings that are treated as errors and those will fail the build of the React app. If you click on the Details link, it will take you to the console output that shows you these warnings that need to be addressed:

src/components/Toggle.js
  Line 13:88:  No duplicate props allowed  react/jsx-no-duplicate-props
  Line 15:88:  No duplicate props allowed  react/jsx-no-duplicate-props

You will also see these in your terminal when you run npm start

sunithapatel commented 3 years ago

@Priyami good job with this, it looks really awesome! 👏🏼 ❤️ I had one question on the css for @princiya but other than that, it looks really good!

And you fixed the build - woohoo! 🥳 Great job!!!

princiya commented 3 years ago

good work @Priyami 👏

Priyami commented 3 years ago

@sunithapatel & @princiya Thank you!