frontendstudygroup / frontendstudygroup.github.io

Web application for the frontend study group from WomenWhoCode Frontend track.
https://frontendstudygroup.github.io/
17 stars 17 forks source link

Added Dockerfile and Nginx Conf for Docker Image #53

Closed awantika10 closed 3 years ago

awantika10 commented 3 years ago

The following steps has been done so far for #8 :

Please do let me know if there are any changes as this would be my first contribution to Cloud :)

princiya commented 3 years ago

@awantika10 great PR 👏 .

Can you add the following Docker related info into readme too?

To test it out locally, used docker compose And also elaborate how to use Docker itself for folks to understand better.

princiya commented 3 years ago

@sunithapatel I will let you review this PR. In the next PR, can we have Github Actions use this Dockerfile for deployment?

awantika10 commented 3 years ago

@awantika10 great PR 👏 .

Can you add the following Docker related info into readme too?

To test it out locally, used docker compose And also elaborate how to use Docker itself for folks to understand better.

Sure

awantika10 commented 3 years ago

@sunithapatel All the changes are resolved :) Also, do I need to change the alpine version of the node?

sunithapatel commented 3 years ago

@sunithapatel All the changes are resolved :) Also, do I need to change the alpine version of the node?

Yes please, you can use 16-alpine.

awantika10 commented 3 years ago

@sunithapatel All the changes are resolved :) Also, do I need to change the alpine version of the node?

Yes please, you can use 16-alpine.

Done :)

sunithapatel commented 3 years ago

@sunithapatel I will let you review this PR. In the next PR, can we have Github Actions use this Dockerfile for deployment?

Sorry @princiya forgot to reply here. I am not sure yet about using this for deployment since it has to be run in something that knows how to run containers like a cloud provider, but we are not there yet. I will have to think about this one. 🙂