search

frontlinesms / grails-yui-war-minify-plugin

Grails plugin to run yui-compressor on css and javascript resources at WAR creation time.
3 stars 3 forks source link

Exception during CreateWar event does not cause CreateWar process to fail #8

Open geoffreymuchai opened 10 years ago

geoffreymuchai commented 10 years ago

We had a problem where some bad Javascript was preventing other CreateWarEvent consumers from consuming the event due to an exception thrown by this plugin. What would be more ideal would be for the build process to fail gracefully in case there is a fatal Javascript error within the application. If this is impossible, then this plugin should allow this event to propagate to other plugins when an exception occurs.

okal commented 10 years ago

This appears to be a problem in the createWar event model itself, rather than the plugin. The process should fail if an exception is thrown in any of the event listeners.

alxndrsn commented 10 years ago

Any idea if this works with newer grails versions?