Closed jrhunger closed 3 weeks ago
Just commenting to let you know I saw this and will hopefully get to it soon. The failing test should be easy to fix, but I want to pull down your PR and fix it locally to verify it first.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 99.7%. Comparing base (
c9f49bb
) to head (d60076c
). Report is 22 commits behind head on dev.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks for the guidance. All tests are passing now.
Thanks! 👍
I think this fix is incomplete, as now owls and lotus cameras are missing after first authentication. I think get_homescreen
is called to early as discussed in https://github.com/fronzbot/blinkpy/issues/917#issuecomment-2138427343 .
Description:
Implementing fixes discussed in #917 log.
Unable to retrieve cameras from response
error after entering PIN on initial auth.I have tested that these changes work with a flow similar to that in blinkapp:
They don't currently pass the tox tests and i think it is because i'm referencing the user_id of the login_data response and that isn't in the mock test response. I'm happy to work on getting the tox tests to pass but would appreciate pointers from someone who is more familiar with the test framework.
Related issue (if applicable): fixes #917
Checklist:
tox
run successfully PR cannot be meged unless tests pass