search

frostming / legit

Git for Humans, Inspired by GitHub for Mac™.
https://frostming.github.io/legit
BSD 3-Clause "New" or "Revised" License
5.7k stars 218 forks source link

remove old reference to six #277

Closed a-detiste closed 9 months ago

weakish commented 9 months ago

Thanks for contributing to legit.

Sorry I am not familiar with pipenv. Can you add more information about why the reference to six is considered "old"?

My attempt to figure out which library depends on six:

I run pipenv graph (Python 3.11.6, macOS Ventura), and it seems that six is still used by one of the indirect dependency:

; pipenv graph
# ... (unrelated graph omitted)
pytest-cov==2.7.1
# ...
└── pytest [required: >=3.6, installed: 5.1.2]
# ...
    ├── packaging [required: Any, installed: 19.2]
    │   ├── pyparsing [required: >=2.0.2, installed: 2.4.2]
    │   └── six [required: Any, installed: 1.11.0]

In other words, according to pipenv graph, pytest-cov depends on pytest, pytest depends on packaging, and packaging depends on six.

frostming commented 9 months ago

Run a real pipenv update instead of only removing one entry.

a-detiste commented 9 months ago

Thanks. I ll send a PR against packaging first.

I never used pipenv, I m used to package everything and the rest as Debian packages.

Le lun. 16 oct. 2023, 08:53, Frost Ming @.***> a écrit :

Run a real pipenv update instead of only removing one entry.

— Reply to this email directly, view it on GitHub https://github.com/frostming/legit/pull/277#issuecomment-1763842538, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB47WUDQVT2SANKTNOZJAW3X7TKX5ANCNFSM6AAAAAA5ZICLEU . You are receiving this because you authored the thread.Message ID: @.***>

weakish commented 9 months ago

I ll send a PR against packaging first.

@a-detiste Recent versions of packaging do not depend on six any more. (pypa/packaging#331)

I think you may update the version requirement for pytest and pytest-cov in Pipfile, then run pipenv update to update the lock file and check if all tests still passed.

(I'll leave this PR as closed for now but feel free to push new changes to your branch. And when it is ready, we can reopen and merge it. Or you can create a new PR if you find that is more convenient for you.)