search

frostming / unearth

A utility to fetch and download python packages
https://unearth.readthedocs.io
MIT License
141 stars 18 forks source link

fix: lock requests version to 2.29.0 #59

Closed vvanglro closed 1 year ago

vvanglro commented 1 year ago

Fixes: pdm issue #2091

Related requestsquestion link: #6443

frostming commented 1 year ago

Sorry, can you describe the details of the issue and your investigation that makes you believe this is the only viable way to fix it? We don't want a solution that "happens to make it work".

You mentioned #2091 but that issue is related to cachecontrol which is not included in this project.

vvanglro commented 1 year ago

You mentioned #2091 but that issue is related to cachecontrol which is not included in this project.

What does mean in relation to cache control? I saw that the error message was sent from the unearth library. https://github.com/pdm-project/pdm/issues/2091#issue-1792585284

vvanglro commented 1 year ago

Sorry, can you describe the details of the issue and your investigation that makes you believe this is the only viable way to fix it? We don't want a solution that "happens to make it work".

For now, people who encounter the same error are solved by locking requests version 2.29.0. https://github.com/psf/requests/issues/6443#issuecomment-1568210854

frostming commented 1 year ago

For now, people who encounter the same error are solved by locking requests version 2.29.0. psf/requests#6443 (comment)

I would like to see more investigation into the nature of the bug. "do A and the bug is gone, so the solution is to do A" isn't enough.

vvanglro commented 1 year ago

Yes, I agree. Needs more investigation as I couldn't reproduce either. Maybe something to do with the network used locally.