search

frostney / react-native-create-library

:notebook: Command line tool to create a React Native library with a single command
MIT License
1.45k stars 114 forks source link

Generated Windows libraries should have unique GUID #13

Closed rozele closed 8 years ago

rozele commented 8 years ago

Each project in a given native solution should have a unique GUID. As such, you'll need to generate a GUID and parameterize here: https://github.com/frostney/react-native-create-library/blob/master/templates/windows.js#L10, here https://github.com/frostney/react-native-create-library/blob/master/templates/windows.js#L30-L53, and here https://github.com/frostney/react-native-create-library/blob/master/templates/windows.js#L195.

frostney commented 8 years ago

Thank you for creating the issue. I'll get right on that once I get home.

rozele commented 8 years ago

@frostney Already put up a PR :-)

frostney commented 8 years ago

Sweet, thank you so much!

frostney commented 8 years ago

Thank you for your fixes. Much appreciated. I just released version 1.0.3 which includes the fixes from both of your pull requests from today.