search

frostney / react-native-create-library

:notebook: Command line tool to create a React Native library with a single command
MIT License
1.45k stars 114 forks source link

Revert automatic linking of React.xcodeproj #55

Closed maicki closed 6 years ago

maicki commented 6 years ago

Automatic linking with React.xcodeproj (#44) broke react-native link. React should not be linked in the library xcodeproj as React would be linked twice if you link it in your final React Native project.

To work on or test a new library, a new React Native project or a new Xcode Project workspace should be created and the newly created library and React should be linked manually or via react-native link.

A good description how to test a new library with a workspace is in #38 from @DavidPotter.

thorbenprimke commented 6 years ago

@maicki - still going to merge this?

maicki commented 6 years ago

Yeah we should merge this otherwise creating a new lib and link it via react-native link will not work. cc @frostney

maicki commented 6 years ago

cc @frostney Any thoughts?

maicki commented 6 years ago

@thorbenprimke Thanks for reviewing