search

frostney / react-native-create-library

:notebook: Command line tool to create a React Native library with a single command
MIT License
1.45k stars 113 forks source link

Add postinstall removing of example #69

Closed osdnk closed 6 years ago

osdnk commented 6 years ago

Using the newest version from master with automatically generated example I faced a problem when I ran react-native start with duplication of dependencies. example folder is being copied while installing example (because of file:../ dependency). The solution is imo to add some postinstall script (like here I have done) :)

xoxoxoooxx commented 6 years ago

Hi Can you share your step about initializing react-native-create-library? I got "Redefinition of 'RCTMethodInfo'" error in iOS.

osdnk commented 6 years ago

Welp @xoxoxoooxx, I don't remember clearly and didn't manage to find in history of my terminal. But frankly speaking I didn't face anything unexpected following Readme. Take into consideration that I was using my fork with bumped version ¯_(ツ)_/¯.

osdnk commented 6 years ago

Oh, and maybe remember to remove "example" and "node_modules" from example/node_modules/yourlibname

xoxoxoooxx commented 6 years ago

Thank you, @osdnk. I decided rebuild my library all over again, then everything is fined.

maicki commented 6 years ago

Hey all - this PR should fix this issue: #75 and does some more improvements around our example creation.