frostney / react-native-create-library

:notebook: Command line tool to create a React Native library with a single command
MIT License
1.45k stars 113 forks source link

blank line at top of xcodeproj/project.pbxproj file breaks react-native link #9

Closed Traviskn closed 8 years ago

Traviskn commented 8 years ago

While testing the installation process of a library I created with this tool, running react-native link produced an error 'Expected "{" found "/"'. This is because there is an extra blank line at the top of the xcodeproj/project.pbxproj file that is confusing the link command. After removing the blank line, the link command worked without errors.

frostney commented 8 years ago

Hi @Traviskn, thank you so much for the report.

frostney commented 8 years ago

Hi @Traviskn, would you mind checking if #10 would fix the problem?

Traviskn commented 8 years ago

Thanks @frostney, I've tested and #10 fixes this problem - react-native link works great!

frostney commented 8 years ago

Thank you so much for testing. I'll release a new version once I got home.

frostney commented 8 years ago

I just released version 1.0.2 which includes the fix. Thank you again for testing, much appreciated 👍

Traviskn commented 8 years ago

No problem, thanks for being so responsive! Thanks to your library, I got my first react native npm package published: https://www.npmjs.com/package/react-native-uuid-generator 🎉