search

frostschutz / MyBB-Google-SEO

Search Engine Optimization plugin for MyBB.
https://community.mybb.com/thread-202483.html
GNU General Public License v3.0
30 stars 25 forks source link

use str_replace instead of eval #11

Closed frostschutz closed 14 years ago

frostschutz commented 14 years ago

Currently, eval is used to expand some of the variables in setting strings. Since the number of useful variables is limited, str_replace should be used instead, since eval also allows execution of other code. For someone with admin priviledges this can be an issue.

frostschutz commented 14 years ago

Google SEO now uses {url} instead of {$url} in its scheme and uses google_seo_expand() (str_replace) to replace these variables with their values.