search

frostschutz / MyBB-Google-SEO

Search Engine Optimization plugin for MyBB.
https://community.mybb.com/thread-202483.html
GNU General Public License v3.0
30 stars 25 forks source link

Going to a deleted/nonexistent thread generates a permission error #30

Closed dandv closed 13 years ago

dandv commented 13 years ago

I just got this report from a user who was subscribed to a forum, got an e-mail notification of a new thread, but by the time they click on the the link, the OP deleted the thread. My user was confused because the error message kept mentioning permissions, and the user is a moderator.

Here's a live example from a random MyBB instance that uses Google SEO: http://www.pavementsucks.com/board/thread-that-doesnt-exist

I've just hacked my messages.lang.php and now the error mentions the thread being deleted as the most probable cause: http://forum.quantifiedself.com/thread-that-doesnt-exist

There must be better solutions, though, perhaps identifying if the URL starts with the thread prefix and issuing an error that "The specified thread does not exist", like here: http://community.mybb.com/thread-999999.html

frostschutz commented 13 years ago

That's MyBB issue.

http://forum.quantifiedself.com/showthread.php?tid=3215782357

You haven't updated to 1.6.4 yet?

dandv commented 13 years ago

Haven't updated yet. Thanks for the tip.

Though I tried this on some older instances of MyBB, e.g. 1.4.13 at http://www.mybbaddons.com/board/showthread.php?tid=9999, and they show the correct message already ("Thread does not exist").

frostschutz commented 13 years ago

Yes, it's a regression in MyBB, not sure when it was introduced.