New Reply Notification Breaks

[CraigTumblison]

Hello,

Earlier today a member of my forum notified me that the "from" field of a notification email was broken. After doing some research into the issue, I found many other posts regarding the very same issue left unanswered. The common theme appears to be the Google SEO Plugin we all have enabled. When we disable all plugins, the problem is instantly solved.

Here's a screenshot of the problem: http://screensnapr.com/v/ZBuM8N.jpg

*Please note that the one where it is working fine was the test with plugins disabled. Also note that email notifications remain completely unaffected.

Here is a link to one such topic that was left unanswered, but reinforces that this is indeed a problem: http://community.mybb.com/archive/index.php/thread-106145-1.html

I did notice a strange occurrence in the email source as documented below: (the top one is from the test with plugins disabled, the bottom sent normally) http://screensnapr.com/v/xLKAwI.jpg

Any help at all on this issue would be fantastic.

Thanks.

[frostschutz]

When we disable all plugins

Please try to deactivate only Google SEO (the plugin can be deactivated/activated at no loss of data or settings).

Can you confirm that the issue is exclusive to Google SEO, i.e. it only appears when Google SEO is activated, and never appears when it is deactivated?

[CraigTumblison]

We have narrowed it down to your plugin using the following logic: -When all plugins are deactivated (using the general config method), the problem is solved. -When plugins are disabled manually on the plugin page, the problem remains. -The only plugin we all have in common is the Google SEO Plugin.

We firmly believe it to be an issue with this specific plugin, most likely with the core template changes associated with it. None of our other plugins touch core files.

[frostschutz]

most likely with the core template changes associated with it

Does the issue go away if you revert Google SEO's core file changes?

With core file changes reverted and Google SEO deactivated, if the issue persists, it's not Google SEO's fault, as that state is equivalent to a complete uninstall of Google SEO.

If you find that this is related to Google SEO being activated and/or core file changes, please try activating Google SEO, but deactivating all of its modules (404, Meta, Redirect, Sitemap, URL) in the main setting group. Then only enable one module at a time (always check plugin status to reapply core file changes). Which module makes the issue appear? If no single module causes the issue, try URL and Redirect together.

As long as I can't reproduce the issue, I can't fix it. Google SEO is not involved at all with sending mails, so I don't even know where to start looking for the problem. If the issue appears in your board, you have to narrow it down for me, otherwise I can not help you.

[CraigTumblison]

After reverting the core template changes via the ACP and disabling the plugin, the problem is still there. After disabling all plugins manually the problem is still there. Only when we use the setting to prevent them from running does the problem disappear. This could mean that changes aren't reverting correctly, and Google SEO is the only plugin that makes core changes.

I'll continue to investigate and see if completely uninstalling / replacing the core files with fresh copies is able to do solve the problem. I suppose I should look into the PluginLibrary Plugin as well, since everyone who has Google SEO will also have that.

Thanks for the help.

[frostschutz]

Google SEO only changes one file (inc/functions.php). You can use MyBB's file verification to see if it's any different from original after reverting. You can get a fresh one out of a MyBB package for your MyBB version (if you are not running latest MyBB, see the MyBB Wiki Versions page.

But everything you told me points to this being a MyBB bug, and those are simply not my responsibility, sorry.

[CraigTumblison]

After using the MyBB File Verification, I guess that rules out Google SEO. I also completely removed all plugins and the problem continued, making this indeed a MyBB Bug.

I've gone ahead and posted everything I know in the official MyBB support forum ( http://community.mybb.com/thread-114598.html ) - I include a link in case any future searchers land here via Google.

Thanks again for the help through this. Clearly if it is confirmed to be a MyBB bug it is not your responsibility. Thanks again.

[frostschutz]

Right, I'll close this issue then. Feel free to reopen / report a new bug with new info, if you find something substantial to this plugin, with steps to reproduce. Thanks.