frostschutz / MyBB-Google-SEO

Search Engine Optimization plugin for MyBB.
https://community.mybb.com/thread-202483.html
GNU General Public License v3.0
30 stars 25 forks source link

Not working #53

Closed ahranchwi closed 10 years ago

ahranchwi commented 10 years ago

This plugin is incompatible with MyBB 1.8.0

Ardakilic commented 10 years ago

@ahranchwi I'm currently using with MyBB 1.8, just altered the compatibility. Works great so far.

Edit this line:

https://github.com/frostschutz/MyBB-Google-SEO/blob/master/inc/plugins/google_seo/plugin.php#L58

"compatibility" => "16*",

Like this:

"compatibility" => "16*,18*",

And try reinstalling.

Edit: Not to mention you need to do the same for PluginLibrary.

ahranchwi commented 10 years ago

Think You Sir Now showing "Install & Activate". But when i click on "Install & Activate" Its open same page and not install plugin sorry for poor English error .

Ardakilic commented 10 years ago

@ahranchwi Did you do it for the PluginLibrary also? This plugin depends on PluginLibrary, and you must do the same trick for it and install/activate it first.

ahranchwi commented 10 years ago

Yes i do it for the PluginLibrary also. But same problem withe PluginLibrary

Ardakilic commented 10 years ago

I don't know mate. With pluginlibrary upgraded it just worked on my end. I guess @frostschutz would answer better I guess..

frostschutz commented 10 years ago

In PluginLibrary, no change whatsoever is necessary. Technically PL is not a plugin, so the compatibility line doesn't matter either. As for Google SEO, I just added the 18* to the compatibility here on GitHub, so if you download the current master from here ( https://github.com/frostschutz/MyBB-Google-SEO/archive/master.zip ) you should be good.

I'll do a real update at some later time...