frostschutz / SourceLib

Python implementation of Valve Source Dedicated Server Query/RCON/Log protocols.
39 stars 20 forks source link

UID maximum length is not enough #5

Closed viviicat closed 13 years ago

viviicat commented 14 years ago

Hi, I was encountering an odd error where most of the log lines were not being properly parsed, when I discovered that my server (which is quite popular and doesn't crash much) had been logging UIDs higher than 999--with 4 characters. I discovered that the regex for player uids does not take this situation into account and the maximum UID one can have is 999.

Changing all the UIDs regex's, such as "[0-9]{1,3}" to "[0-9]{1,4}" fixed this issue.

frostschutz commented 14 years ago

Hm, maybe better to just use [0-9]+ so it allows for any number.

Thanks for the report, I'll commit this sometime.

frostschutz commented 13 years ago

fixed