search

frostwire / frostwire-jlibtorrent

A swig Java interface for libtorrent by the makers of FrostWire. Develop libtorrent based apps with the joy of coding in Java.
http://www.frostwire.com
MIT License
446 stars 137 forks source link

Private torrents doesn't work #170

Closed proninyaroslav closed 6 years ago

proninyaroslav commented 7 years ago

Hello. I noticed that I can't download private torrents: trackers doesn't work. I also checked this option in frostwire app and I could not download this torrent.

Screenshot with broken tracker: http://imgur.com/GnGaiu7

Torrent file: [CzT]Ubuntu_Budgie_v16_10x64.zip

P.S: It works great in qbittorrent.

aldenml commented 7 years ago

Let me take a look at it (we are using master and I think qBittorrent is still in 1.0.1)

aldenml commented 7 years ago

We don't support HTTPS trackers, we exclude any ssl support from jlibtorrent to save some space in the final binary (but still we use libcrypto for hash acceleration). Adding support in a custom build should be relatively easy, but not sure if worth the trouble, because HTTPS trackers does not provide any meaningful security.

I will close the issue, but feel free to provide arguments if you think this feature is necessary.

J-qak commented 6 years ago

Here are in my opinion good reasons for actually implementing HTTPS tracker support, if I understand correctly. Being not implemented in jlibtorrent doesn't change the fact that some private trackers are already using HTTPS, so apps using jlibtorrent won't let users use these trackers. If I have time, I'll try to experiment with it.

aldenml commented 6 years ago

After discussing the issue internally, we decided to revisit it

aldenml commented 6 years ago

Hi @J-qak, 1.2.0.13-RC5 is already out in maven, can you test it with your HTTPS trackers?

proninyaroslav commented 6 years ago

@aldenml It works perfectly.

aldenml commented 6 years ago

good to know, I'm in the process of making public the remaining support for torrents over SSL