Change client name encoding from ASCII to Unicode.

frostwire / frostwire-jlibtorrent

A swig Java interface for libtorrent by the makers of FrostWire. Develop libtorrent based apps with the joy of coding in Java.

http://www.frostwire.com

MIT License

451 stars 138 forks source link

Change client name encoding from ASCII to Unicode. #208

Closed ghost closed 6 years ago

ghost commented 6 years ago

Currently, client name is converted to ascii, which breaks unicode characters, so µTorrent gets interpreted as "��Torrent". This is at PeerInfo.java:153

I suggest changing it to unicode string: client = Vectors.byte_vector2string(p.get_client(),"UTF-8")

aldenml commented 6 years ago

Thank you for this observation, I will take a look at it, at this moment I have the impression I was making wrong assumptions about how this string is created/used in the real world.

aldenml commented 6 years ago

Hi @persona5 1.2.0.18-RC12 is out in maven with this fixed