frostyfan109 / tranql

A Translator Query Language
https://researchsoftwareinstitute.github.io/data-translator/apps/tranql
MIT License
0 stars 1 forks source link

Browse + Answer Viewer #108

Closed stevencox closed 5 years ago

stevencox commented 5 years ago

Perhaps we should disable the answer viewer when browsing is happening.

image image

frostyfan109 commented 5 years ago

~I keep forgetting to check, but I think the answer viewer may have been broken again sadly, which would mean this isn't browse node-specific.~ Nevermind, it seems to be working properly without browsing.

frostyfan109 commented 5 years ago

The original error has been fixed. Now the interface just looks like this: image

However, I think I found the culprit of what causes the blank interface:

{
  "nodes": [
    {
      "id": "n0",
      "curie": "DOID:12918",
      "type": "disease"
    },
    {
      "id": "n1",
      "type": "gene"
    },
    {
      "id": "n0",
      "curie": "DOID:1588",
      "type": "disease"
    },
    {
      "id": "n1",
      "type": "gene"
    }
  ],
  "edges": [
    {
      "id": "e0",
      "source_id": "n0",
      "target_id": "n1",
      "directed": true
    },
    {
      "id": "e0",
      "source_id": "n0",
      "target_id": "n1",
      "directed": true
    }
  ]
}

If ids matter to Robokop, then this is a really problem.

stevencox commented 5 years ago

Something must have changed in generate question. We should create one node with multiple identifiers.

frostyfan109 commented 5 years ago

The nodes with curies are being generated by the Robokop API when browse nodes is used. Robokop then returns the results along with this question_graph which we merge into the current question_graph.