Merging master to Tranql(source repo) develop branch

frostyfan109 / tranql

A Translator Query Language

https://researchsoftwareinstitute.github.io/data-translator/apps/tranql

MIT License

0 stars 1 forks source link

Merging master to Tranql(source repo) develop branch #121

Closed YaphetKG closed 4 years ago

YaphetKG commented 4 years ago

Hi @frostyfan109 , i was merging the latest code from this fork to tranql, and had a failing travis test for it I think the failing test is ast_3 = tranql.parse(f""" SET var_str = 'CHEBI:0' SET var_list = ['CHEBI:22', 'CHEBI:33'] SELECT chemical_substance->gene->disease FROM "/graph/gamma/quick" WHERE chemical_substance = [$var_str, 'CHEBI:1', $var_list] """) fails to create four quiestions of those CHEBI curies, (https://travis-ci.org/github/NCATS-Tangerine/tranql/builds/718416664)

frostyfan109 commented 4 years ago

Thanks for opening this. I'm aware of the failing test and opened an issue on what's causing it. In short, there is a bug which causes the specific feature the unit test is made for to be broken. This feature is also in the master repo and so is the bug. It's just the test which is new.

frostyfan109 commented 4 years ago

I've fixed the bug in #122 which the unit test was addressing. There was some small reason why I hadn't already done this, but I can't seem to remember it.

YaphetKG commented 4 years ago

Thank you much!