frostyfan109 / tranql

A Translator Query Language
https://researchsoftwareinstitute.github.io/data-translator/apps/tranql
MIT License
0 stars 1 forks source link

TranQL should throw an error if it receives a question that does not comply with its schema. #29

Closed frostyfan109 closed 5 years ago

frostyfan109 commented 5 years ago

Currently, TranQL only checks if each concept exists in the schema, but does not verify that the connection exists between each concept. It should be fairly simple to also verify this, and it would be useful to the user. At the moment, TranQL just sends the query to the services and the user sees whatever error the service throws when no transitions exist.

frostyfan109 commented 5 years ago

Fixed.

frostyfan109 commented 5 years ago

Unit tests selecting population_of_individual_organisms->drug_exposure fail because no transition between these two types exists. Does TranQL somehow infer a transition? If it does, that means that we cannot raise an error if only no direct transition exists. Until this is clarified, the issue will be reopened.