Merge results does not correctly handle conflicting edge ids

frostyfan109 / tranql

A Translator Query Language

https://researchsoftwareinstitute.github.io/data-translator/apps/tranql

MIT License

0 stars 1 forks source link

Merge results does not correctly handle conflicting edge ids #43

Closed frostyfan109 closed 5 years ago

frostyfan109 commented 5 years ago

Multiple answers can return completely different edges that have the same ids (e.g. e0). This is not currently handled at all in merge_answers, and therefore it is possible to lose links in the force graph.

To fix, we could replace all edge ids in the responses with uuids before merging.

Note: this probably also occurs with nodes?

frostyfan109 commented 5 years ago

Related to #54

frostyfan109 commented 5 years ago

This is not actually an issue - edge ids are irrelevant and node ids will always be the node's curie (identifier).