search

frostyfan109 / tranql

A Translator Query Language
https://researchsoftwareinstitute.github.io/data-translator/apps/tranql
MIT License
0 stars 1 forks source link

Find tool incompatible and find tool rendering becomes extremely slow when many results are loaded #52

Closed frostyfan109 closed 5 years ago

frostyfan109 commented 5 years ago

Currently, the find tool uses regex only supported by chrome. This means that TranQL's website no longer works on any other browsers. It looks like it is something to do with the look aheads and look behind used by it. The expression /(?<=:)(?<!\\:).*/g specifically is what causes the error, but many other expressions use this syntax and therefore likely do not work either.

The find tool should not have to reload everytime the App's state changes. It should be adjusted to only update whenever anything that could change the find tool's results changes.

frostyfan109 commented 5 years ago

Fixed performance.

frostyfan109 commented 5 years ago

Update: lookbehinds are only supported by browsers supporting the ECMA2018 standard, so only Chrome really supports them as of now. They'll have to be replaced.

frostyfan109 commented 5 years ago

Lookbehinds in the FindTool's regex have now been written out, so it should be supported in modern browsers.