search

froxlor / Froxlor

The server administration software for your needs - The official Froxlor development Git repository
http://www.froxlor.org
GNU General Public License v2.0
1.63k stars 453 forks source link

ignore package-lock.json #1181

Closed rubo77 closed 1 year ago

rubo77 commented 1 year ago

This file should not be within the git repository, since it is automatically edited, when you run the install instructions:

composer install --no-dev
npm install
npm run build
d00p commented 1 year ago

same as composer.lock, it represents the package versions installed/tested for a release and thus used for building the release packages (instead of package.json).

Also relevant for developers: It allows future devs to install the same dependencies in the project.

rubo77 commented 1 year ago

Ah ok. So would you like to see the changes to the file, that were automatically made in my repository, and update the file then?

d00p commented 1 year ago

You obviously don't understand and rather discuss meaningless on GitHub then talk to us on discord.

discordier commented 1 year ago

For the record, install as follows:

composer install --no-dev
npm ci
npm run build

See https://docs.npmjs.com/cli/v9/commands/npm-ci

That way you get the dependencies as intended.

npm install is for developers that want to get current dependencies.