search

froxlor / Froxlor

The server administration software for your needs - The official Froxlor development Git repository
http://www.froxlor.org
GNU General Public License v2.0
1.63k stars 453 forks source link

PHP-FPM config not updated when OpenBasedir entry is changed #1200

Closed mas1701 closed 10 months ago

mas1701 commented 10 months ago

Running Froxlor on Debian 10.13 Froxlor v2.0.24 Web server: apache2 + PHP-FPM

I didn't believe my eyes when I stumbled across this, as it seems so basic, but here we go:

To Reproduce

  1. As an admin, create a domain with any PHP-FPM configuration. Choose any OpenBasedir setting for PHP.
  2. Wait for configuration to get activated. (No more tasks for Froxlor remaining.)
  3. Check OpenBasedir setting in generated file in /etc/php/[version]/fpm/pool.d/[domain].conf .
  4. Change domain configuration, choosing any other OpenBasedir setting than the current one.
  5. Check file in /etc/php/[version]/fpm/pool.d/[domain].conf again (after next Froxlor cron update run).

Expected behavior Changing the OpenBasedir setting at 4. should trigger another Froxlor web server configuration update, but does not.

Workaround Instead of changing the OpenBasedir setting only, do another change at the same time, say add a good-for-nothing "# comment" to the VHost configuration field. This WILL trigger an update and therefore the OpenBasedir setting is written as well.

Note This bug seems to apply to the admin user only. When the customer changes his/her own domain, the OpenBasedir change triggers the update.