search

froyg / thittam

1 stars 4 forks source link

Use *this instead of this in sigc::mem_fun #19

Closed Compro-Prasad closed 6 years ago

Compro-Prasad commented 6 years ago

Passing pointer to sigc::mem_fun is deprecated and might be removed in future. So, it is better to fix it now.

Compro-Prasad commented 6 years ago

Any problem with this?

joshuaimmanuel commented 6 years ago

For reference, I am posting the link explaining the change in the libsigc++ API

https://www.murrayc.com/permalink/2016/03/17/libsigc-stdfunction-style-syntax/

The commit seems fine.

Compro-Prasad commented 6 years ago

I think I should update this PR. Has merge conflicts.

joshuaimmanuel commented 6 years ago

Yeah. That would be great.

Compro-Prasad commented 6 years ago

Closing this in favour of https://github.com/froyg/thittam/pull/21