frozenpandaman / s3s

Successor to splatnet2statink. Takes battle data from the SplatNet 3 app and uploads it to stat.ink!
https://github.com/frozenpandaman/s3s/wiki
GNU General Public License v3.0
394 stars 72 forks source link

v0.6.0 roadmap #155

Closed frozenpandaman closed 8 months ago

frozenpandaman commented 9 months ago

v0.5.0 roadmap: https://github.com/frozenpandaman/s3s/issues/128

Maybe:

niyari commented 9 months ago

https://github.com/frozenpandaman/s3s/blob/18ac2ebdc7fe3f9d55a716a64fce6500707e0952/iksm.py#L9 -> True

frozenpandaman commented 9 months ago

@niyari Oh, great! That didn't work for me during my testing, so I thought there was an issue, but I was doing it at 3 a.m. so I probably was doing it wrong 😆

Still, the Salmon Run job details query needs to be changed to the new value, and possibly a couple other fields supported (depending on what stat.ink does) so I'll leave this open for now...

qjzcj2008 commented 9 months ago

f generation provided by imink now supports 2.8.0 version NSO app, so I think now there's no need to fallback to version 2.7.1.

And I add support for new SR SPs added in ver6.0.0, and updated NSO app fallback version & splatnet 3 version hash.

And I see seems that stat.ink is already prepared for the new SR SPs & the coming Big Run.

158

frozenpandaman commented 9 months ago

156 and #158 merged.

I'll wait on bumping the version number to v0.6.0 until I can look at #144 & #145 in a couple days.

qjzcj2008 commented 9 months ago

The f API is always associated with the NSO version number. Mismatched NSO version sent to The f API could result in errors, just like this time.

So I think get NSO version number from Apple App Store may not the best choice, and the major f APIs provide a /config endpoint to provide the NSO version they're running. Maybe use NSO version from f APIs will be better.

I make a PR about this.#159 It should be compatible with existing version s3s, and when get NSO version from The f APIs failed it will fallback to APP Store.

frozenpandaman commented 8 months ago

v0.6.0 is now out: 059b3ea

Sorry for the delay; all users should now be prompted to auto-update which will fix the new specials in SR issue (without having to manually do a git pull) along with other improvements.

frozenpandaman commented 8 months ago

Re-opening & "downgraded" back to v0.5.7 for the time being as #159 introduces a breaking error.

frozenpandaman commented 8 months ago

Fixed in c110e2e / 3f3691f, v0.6.0 re-released :^)