search

frozenpandaman / s3s

Successor to splatnet2statink. Takes battle data from the SplatNet 3 app and uploads it to stat.ink!
https://github.com/frozenpandaman/s3s/wiki
GNU General Public License v3.0
394 stars 72 forks source link

add support for ver.6.0.0 new SR specials & update NSO app version and splatnet 3 version hash #158

Closed qjzcj2008 closed 9 months ago

qjzcj2008 commented 9 months ago

I add support for new SR SPs added in ver6.0.0, and updated NSO app fallback version & splatnet 3 version hash.

And tested on my side it works fine.

Lokno commented 9 months ago

Pulled this branch and tested it. Successfully uploaded all my un-uploaded jobs which were producing the unknown special error.

frozenpandaman commented 9 months ago

Thank you! I'm traveling this weekend and don't have a computer with me but this all looks good and I can get it merged tonight. Can you bump the version to 0.6.0 as well?

EDIT: Unless there's other changes that need to be made... not sure if anything regarding X Power logic, for example, should be updated now. Might you be able to provide any insight @cesaregarza? I've been busy IRL and haven't been following the update closely enough to have a sense of this.

cesaregarza commented 9 months ago

There's no X Power changes that the existing logic does not handle, it's a change done on how the X Power is calculated, but on the NSO view there shouldn't be any change iirc.

frozenpandaman commented 9 months ago

Thanks!

The SR changes were already included in #156 and I've just merged that PR.

frozenpandaman commented 9 months ago

I'll actually update to 0.6.0 later (in a couple days) to include a few other PRs, so can merge this now.