search

frozenpandaman / s3s

Successor to splatnet2statink. Takes battle data from the SplatNet 3 app and uploads it to stat.ink!
https://github.com/frozenpandaman/s3s/wiki
GNU General Public License v3.0
394 stars 72 forks source link

Make lowercase `-M` work #163

Closed frozenpandaman closed 6 months ago

frozenpandaman commented 8 months ago

Someone messaged me (please don't do this, open an issue here) saying that having to press the shift key every time they use the -M option is messing them up because they keep typing it wrong. Despite this being very funny, I do admit I have no idea why I made -M uppercase in splatnet2statink however many years ago now – it was probably an arbitrary choice and is a little unexpected/inconsistent, one could argue!

Filing this issue as a reminder to add in (silent) support for -m (if it's not too complicated/annoying to do with argparse). Just have it treat it as uppercase instead, in case users mistype it.

Could probably also support upper/lowercase being treated the same for all flags, frankly.

niyari commented 8 months ago

Low priority suggestion: Update README; For questions that require code changes, please ask on GitHub.

frozenpandaman commented 8 months ago

The readme already says "Have any questions, problems, or suggestions? Create an issue here or contact me on Twitter. Please do not raise issues via Discord."

Despite that, this person messaged me on Discord. Oh well.

frozenpandaman commented 6 months ago

Merged in 4d08f96