frozenpandaman / s3s

Successor to splatnet2statink. Takes battle data from the SplatNet 3 app and uploads it to stat.ink!
https://github.com/frozenpandaman/s3s/wiki
GNU General Public License v3.0
394 stars 72 forks source link

Use "rengo" keyword to upload triumvirate "オカシラ連合" salmonrun result #183

Closed gecko655 closed 2 months ago

gecko655 commented 2 months ago

At this moment, stat.ink accepts ID 26 as triumvirate but actually Splanet3 returns it as ID 30.

In the meantime until stat.ink is fixed, this PR make s3s send the result of triumvirate via its alias "rengo".

As this is urgent patch until the fix of stat.ink, it does not need to be merged. I made this patch just in case the s3s users in a hurry want to use it.

frozenpandaman commented 2 months ago

cc @fetus-hina

Hina is usually fast enough at these sorts of fixes that this PR may not be necessary :) Thanks for the heads up!

frozenpandaman commented 2 months ago

Patching for now just because Big Run is ongoing & because this doesn't require a version bump (users who are actively playing and run into the issue can update manually to resolve the error, though I expect it to be fixed on stat.ink's end pretty soon)

Will revert later (just to keep the code cleaner)

frozenpandaman commented 2 months ago

Now fixed on stat.ink's end

https://github.com/fetus-hina/stat.ink/issues/1297 https://github.com/fetus-hina/stat.ink/commit/05ee41d3462c98abb08c3416bf217b9552709c3e