kill / assist count - Githubissues

frozenpandaman / s3s

Successor to splatnet2statink. Takes battle data from the SplatNet 3 app and uploads it to stat.ink!

https://github.com/frozenpandaman/s3s/wiki

GNU General Public License v3.0

400 stars 71 forks source link

kill / assist count #30

Closed paul-sama closed 2 years ago

paul-sama commented 2 years ago

kill and assist count seem different between splatoon2 and splatoon3 sp2: kill = kill ，assist = assist sp3: kill = kill + assist ， assist = assist

frozenpandaman commented 2 years ago

Are you talking about in-game or on SplatNet? Both games show "kills+assists" as the number on the in-game scoreboard.

On both SplatNet 2 and 3, the scoreboard shoes kills+assists <assists>. I think the numbers are sent to stat.ink correctly?

https://github.com/frozenpandaman/s3s/blob/e14cd3187f24dcc63999db3c530e346a99bf1037/s3s.py#L470-L472

paul-sama commented 2 years ago

I think is stat.ink bug NSO app show x11<4>

frozenpandaman commented 2 years ago

Interesting. Do you happen to have the exported JSON file that includes that battle, just so I can double check? If it was in your most recent 50 ones played, you can just run s3s with -o and post the results.json that it spits out here.

paul-sama commented 2 years ago

"result": { "kill": 11, "death": 14, "assist": 4, "special": 1, "noroshiTry": null }

frozenpandaman commented 2 years ago

@paul-sama I think I was just misunderstanding, and then wasn't thinking clearly (addition is hard for middle-of-the-day eli, I guess…)

Everything looks correct.

That battle shows 11 kills, 4 assists 11 + 4 = 15 "kill or assist"s

paul-sama commented 2 years ago

15 is correct count?

frozenpandaman commented 2 years ago

oh my GOD you're right. result.kill is really kills + assists 🤦 nice job nintendo.........

note: on splatnet 2, player_result.kill_count is, as the name implies, just kills – not k+a. so they changed it this time around and labeled it the most confusing (and wrong!?) thing ever.

just confirmed in a recent match of mine from tonight too: i got 11 kills and 2 assists, and splatnet shows x13<2>

thank you SO much for pointing this out

fetus-hina commented 2 years ago

We disscussed about this issue in our dev Discord.

Eli will release s3s which fixes this problem.
Already registered data will be automatically corrected on the stat.ink side.

This will fix the problem of the incorrect team total value of the kills and deaths.

Thank you for the report.

frozenpandaman commented 2 years ago

Fixed in 63b8231 (v0.1.3)! Thanks again so much @paul-sama and sorry again for all the trouble I had in understanding this at first. Very grateful to have this pointed out.

And thank you Hina for fixing the already-uploaded-to-the-site battles. 🙏

fetus-hina commented 2 years ago

Sorry for the delay, but the correction of the data registered in the past has been completed. (https://github.com/fetus-hina/stat.ink/issues/1088) The data displayed on the stat.ink public site is now correct.

This comment is a record just in case.

frozenpandaman commented 2 years ago

Yay, thanks so much @fetus-hina! Appreciate your help here.