search

frozenpandaman / s3s

Successor to splatnet2statink. Takes battle data from the SplatNet 3 app and uploads it to stat.ink!
https://github.com/frozenpandaman/s3s/wiki
GNU General Public License v3.0
403 stars 72 forks source link

`title_exp_before` must be no greater than 999 #90

Closed frozenpandaman closed 1 year ago

frozenpandaman commented 1 year ago

Bug report from Minaraii on Twitter:

image This error came from a W2 loss EVP 999 -> 994, which only happens when a match has 1 or more player DC. I believe this is due to the data registering an EVP 999 final result as a 979 -> 999, regardless of the starting EVP (e.g. 980 / 985 / 990)?

export.zip

k-ashiya commented 1 year ago

I guess the result says afterGradePoint is 995 and s3s assumes that 1005 -> 995 as a W2 loss, isn't it? Uh-oh... This behavior seems different from in 2. I know point loss is halved when 1 or more players DC, but it's also true when players have a large diff in EVP I think. So tracing the previous result via previousHistoryDetail or passing EVP as next function args seems better.

frozenpandaman commented 1 year ago

tracing the previous result via previousHistoryDetail or passing EVP as next function args seems better

@k-ashiya I think you're right. It's slower (an extra request for every job) but it definitely is the most accurate.

This should be fixed in 10dd403!