search

frozenpandaman / splatnet2statink

Takes battle data from the SplatNet 2 app and uploads it to stat.ink
https://github.com/frozenpandaman/splatnet2statink/wiki
347 stars 61 forks source link

update iksm.py #104

Closed tkgstrator closed 4 years ago

tkgstrator commented 4 years ago

Nintendo changed some headers value for NSO update.

frozenpandaman commented 4 years ago

Glad it was an easy fix! Thanks so much!

@tkgstrator, could you bump the version number to 1.5.5? Then I'll merge this. :)

EDIT: Whoops, forgot GitHub allows me to do this now too ("Add more commits by pushing to the master branch on tkgstrator/splatnet2statink") but it looks like you're working on it.

tkgstrator commented 4 years ago

Done.

frozenpandaman commented 4 years ago

I no longer have access to a Windows machine to build the pre-compiled executable for v1.5.5. If you do, could you help me out and build it for me, by chance?

All this involves is installing PyInstaller via pip, and then running the command pyinstaller --onefile --icon=s2s.ico splatnet2statink.py. (ICO file here)

If you're on Windows and could do this, and send me the resulting .exe to host on the repo's releases page, that'd be great!

tkgstrator commented 4 years ago

I've done, here :)

https://github.com/tkgstrator/splatnet2statink/releases/tag/1.5.5

P.S Executable file is little larger than yours lol.

frozenpandaman commented 4 years ago

Thank you so much, really appreciated!

And hah, no worries (hmm, I wonder why it can vary so much?) – the Mac one is always even larger. :)

tkgstrator commented 4 years ago

First time, I thought pyinstaller tried to include all of libraries installed on my computer. So I created virtual environment using anaconda and build it again but did not change. Hmm, I'm curious.

frozenpandaman commented 4 years ago

I am too! Interesting. But no big deal at all. :D