search

frozenpandaman / splatnet2statink

Takes battle data from the SplatNet 2 app and uploads it to stat.ink
https://github.com/frozenpandaman/splatnet2statink/wiki
346 stars 61 forks source link

update headers for NSO app v1.12.0 #123

Closed niyari closed 3 years ago

niyari commented 3 years ago

It looks like these can be made into common variables.

frozenpandaman commented 3 years ago

@niyari Good point! Do you want to make that change now? If so, feel free and then I'll merge the PR. :)

I'm traveling until the 10th and can update the new executable builds (and make sure everything is working there) then.

frozenpandaman commented 3 years ago

ping on this when you have a chance @niyari!

niyari commented 3 years ago

What do you think?🙇 https://github.com/niyari/splatnet2statink/commit/8a1e7512931b110315dca853716562ec7b48c2ba

frozenpandaman commented 3 years ago

Sorry for the delay @niyari, looks good! Can you modify the PR to merge in the patch-1 branch instead of master? (or, push this commit to your master branch so I can merge it?

EDIT: ah, turns out i can :) thank you!

issei-m commented 3 years ago

@frozenpandaman Can you release it?

frozenpandaman commented 3 years ago

Whoops! Forgot all about that, heh…

Thank you @issei-m, done!

issei-m commented 3 years ago

Thank you :)