Make some functions usable from another programs

frozenpandaman / splatnet2statink

Takes battle data from the SplatNet 2 app and uploads it to stat.ink

https://github.com/frozenpandaman/splatnet2statink/wiki

346 stars 61 forks source link

Make some functions usable from another programs #137

Closed hasegaw closed 2 years ago

hasegaw commented 2 years ago

Changes to make the program usable from another host program.

Split post_battle() code to two functions (data parsing and stat.ink uploader)
move splatnet access code from set_scoreboard() to post_battle() to make the data parsing function reusable.
Initialize some variables and import PIL to avoid undefined variables reference if splatnet2statink is imported by another host progiram.

frozenpandaman commented 2 years ago

@hasegaw I think I'll leave this codebase as-is, but as we work to set up the s3s repo in preparation for Splatoon 3, does it sound good if you can ensure everything's in line & structured as needed for IkaLog 3 integration (i.e. what this PR does)? :)

That is, is it OK if I close this PR here, but you can open it again on the upcoming (!) s3s repo, if needed?

hasegaw commented 2 years ago

@frozenpandaman sounds fine to me. closing this item.