search

frozensheep / rightmoveADF

PHP library for the Rightmove Real Time Property Datafeed (ADF).
MIT License
17 stars 20 forks source link

Too many pre-requisites / assumptions #2

Closed honir closed 7 years ago

honir commented 8 years ago

I was very excited when I found this class, but after 2 wasted hours trying to install it I've given up.

  1. Has a (unspecified) dependency of your other library ("synthesize")
  2. Assumes use of "composer"
  3. Requires an autoloader to have been defined (and with this specific path/classes)
  4. Your code class RightmoveADF { use Synthesizer; generates an "invalid T_USE" error (invalid scope)

The nail in the coffin (for me), your Synthesizer class uses traits which means PHP >= 5.4. I wish you'd said that up front.

Thanks for trying and for making it available (even though I personally can't use it)

Sam-R commented 8 years ago

@honir - While I understand your frustrations getting this code working (I am having problems myself), I think it might have been more appropriate to raise issues asking for help. I really appreciate that the author has bothered to make the code open source allowing a head start to my own development work. Keep in mind it's an open source project so if you want to make improvements (even if just the read me) you're able to update the code and submit a pull request.