search

frozn / TipTac

WoW AddOn TipTac Reborn
GNU General Public License v3.0
119 stars 25 forks source link

Get SpellFlyout Direction Nil Value when using Dominos #151

Closed craglin closed 1 year ago

craglin commented 1 year ago

Describe the bug Bug only occurs in conjunction with Dominos action bar manager. On a rogue, attempting to access poisons listing flyout on an action bar..

To Reproduce Steps to reproduce the behavior:

  1. Drag "Poisons" to any action bar.
  2. Click "Poisons" button.

Expected behavior Spell flyout of available poisons.

Screenshots Screenshot not applicable.

TipTac Reborn (please complete the following information):

WoW (please complete the following information):

Additional context BugSack Debug info below: 1x FrameXML/SpellFlyout.lua:240: attempt to call method 'GetSpellFlyoutDirection' (a nil value) [string "@FrameXML/SpellFlyout.lua"]:240: in function Toggle' [string "@FrameXML/SecureTemplates.lua"]:361: in functionhandler' [string "@FrameXML/SecureTemplates.lua"]:690: in function <FrameXML/SecureTemplates.lua:672> [string "@FrameXML/SecureTemplates.lua"]:704: in function <FrameXML/SecureTemplates.lua:697> [string "@FrameXML/SecureTemplates.lua"]:746: in function `SecureActionButton_OnClick' [string "@FrameXML/ActionButton.lua"]:1175: in function <FrameXML/ActionButton.lua:1145>

Locals: self = SpellFlyout { 0 = isActionBar = true MarkDirty = defined @SharedXML/LayoutFrame.lua:90 eventsRegistered = false MarkClean = defined @SharedXML/LayoutFrame.lua:105 OnCleaned = defined @SharedXML/LayoutFrame.lua:114 Toggle = defined @FrameXML/SpellFlyout.lua:206 GetLayoutChildren = defined @SharedXML/LayoutFrame.lua:64 OnUpdate = defined @SharedXML/LayoutFrame.lua:84 GetAdditionalRegions = defined @SharedXML/LayoutFrame.lua:76 IsDirty = defined @SharedXML/LayoutFrame.lua:110 SetBorderSize = defined @FrameXML/SpellFlyout.lua:442 Layout = defined @SharedXML/LayoutFrame.lua:333 SetBorderColor = defined @FrameXML/SpellFlyout.lua:435 IsLayoutFrame = defined @SharedXML/LayoutFrame.lua:36 OnShow = defined @SharedXML/LayoutFrame.lua:32 Background = Frame { } AddLayoutChildren = defined @SharedXML/LayoutFrame.lua:48 IgnoreLayoutIndex = defined @SharedXML/LayoutFrame.lua:329 } flyoutID = 66 parent = DominosActionButton49 { 0 = OnEnter = defined @FrameXML/ActionButton.lua:1200 FlyoutArrowContainer = Frame { } NewActionTexture = Texture { } RightDivider = Frame { } DoModeChange = defined @FrameXML/QuickKeybind.lua:95 MSQ_bType = "Action" __MSQ_NewNormal = Texture { } UpdateButtonArt = defined =[C]:-1 QuickKeybindButtonOnLeave = defined @FrameXML/QuickKeybind.lua:33 UpdateAction = defined @FrameXML/ActionButton.lua:357 OnReceiveDrag = defined @FrameXML/ActionButton.lua:1194 icon = DominosActionButton49Icon { } SlotArt = Texture { } AutoCastable = Texture { } UpdateTooltip = defined @FrameXML/ActionButton.lua:914 UpdateState = defined @FrameXML/ActionButton.lua:494 SetShowCooldowns = defined @Dominos/bars/actionBar/button.lua:82 MSQ_ChargeSkin =

{ } OnDragStart = defined @FrameXML/ActionButton.lua:1182 UpdatePressAndHoldAction = defined @FrameXML/ActionButton.lua:340 MSQ_UpdateButtonArt = true __MSQ_NormalSkin =
{ } HotKey = DominosActionButton49HotKey { } HighlightTexture = Texture { } UpdateOverlayGlow = defined @FrameXML/ActionButton.lua:707 GetPagedID = defined @FrameXML/ActionButton.lua:1005 Update = defined @FrameXML/ActionButton.lua:373 ClearProfessionQuality = defined @FrameXML/ActionButton.lua:540 UpdateShownInsecure = defined @Dominos/bars/actionBar/button.lua:35 QuickKeybindButtonOnEnter = defined @FrameXML/QuickKeybind.lua:22 IconMask = MaskTexture { } MSQ_NormalHook = true Regions =
{ } MSQ_Scale = 1 SetNormalAtlas = defined =[C]:-1 MSQ_Normal = Texture { } SpellHighlightAnim = AnimationGroup { } CheckedTexture = Texture { } OnLoad = defined @FrameXML/ActionButton.lua:279 __MSQ_EmptyType = true PushedTexture = Texture { } SetButtonState = defined @FrameXML/ActionButton.lua:1140 MSQ_Mask = MaskTexture { } SetTooltip = defined @FrameXML/ActionButton.lua:914 Count = DominosActionButton49Count { } MSQ_IsAction = true UpdateUsable = defined @FrameXML/ActionButton.lua:500 __MSQ_Icon = DominosActionButton49Icon { } SetNormalTexture = defined =[C]:-1 FlyoutBorderShadow = DominosActionButton49FlyoutBorderShadow { } GetShowGrid = defined @FrameXML/ActionButton.lua:1227 SetButtonStateBase = defined =[C]:-1 UpdateHotkeys = defined =[C]:-1 MSQ_Enabled = true Q

ghost commented 1 year ago

Dominos is the issue because it's not updated. Blizzard code is the issue because the devs are lazy and no addon dev has found a REAL solution. Dominos has since been abandoned unless you yourself can find a proper solution. https://github.com/tukui-org/ElvUI/issues/571 https://github.com/tullamods/Dominos/issues/641 https://github.com/Nevcairiel/Bartender4/issues/92 https://github.com/Stanzilla/WoWUIBugs/issues/302

lowpita commented 1 year ago

Hey. There was actually a work around for this from nevcairiel, bartender's author. Check changelog: https://www.curseforge.com/wow/addons/bartender4/files/4102728 I don't know about dominos tho. This same rework is implemented into elvui. Also this has nothing to do with tiptac's end.

Tuller commented 1 year ago

I've implemented a workaround in 10.0.13.

frozn commented 1 year ago

Phew... I pushed out many fixes regarding the complete rewrite of ttCore in the last days. It's nice, that some issues solves themselves. 😉

  • © Githubissues.
  • Githubissues is a development platform for aggregating issues.