frozn / TipTac

WoW AddOn TipTac Reborn
GNU General Public License v3.0
109 stars 23 forks source link

ItemLevel calculation error #158

Closed helicdark closed 1 year ago

helicdark commented 1 year ago

It seems the 22.12.15 version counted libram's ilvl two times.

Screenshots WoWScrnShot_121822_114925 Libram of Renewal Equipped (ilvl 200), tiptac shows 223 while TinyInspect says 211

WoWScrnShot_121822_114949 No Libram, now tiptac is the same as TinyInspect.

TipTac Reborn (please complete the following information):

WoW (please complete the following information):

frozn commented 1 year ago

Thanks for reporting this. 👍

Line 1068 of \TipTacTalents\libs\LibFroznFunctions-1.0\LibFroznFunctions-1.0.lua has to be uncommented so that it's active again:

https://github.com/frozn/TipTac/blob/834abf1bdcb31582c6caee5a3289207ed735eef1/TipTacTalents/libs/LibFroznFunctions-1.0/LibFroznFunctions-1.0.lua#L1065-L1069

The fix will be included in the next release.

sharpwg1337 commented 1 year ago

Thanks for reporting this. 👍

Line 1068 of \TipTacTalents\libs\LibFroznFunctions-1.0\LibFroznFunctions-1.0.lua has to be uncommented so that it's active again:

https://github.com/frozn/TipTac/blob/834abf1bdcb31582c6caee5a3289207ed735eef1/TipTacTalents/libs/LibFroznFunctions-1.0/LibFroznFunctions-1.0.lua#L1065-L1069

The fix will be included in the next release.

I uncommented that line and now ilvl doesn't show at all on the tooltip - not blank or N/A, error, etc. it's just gone from the tooltip completely (and yes it is enabled in options)

frozn commented 1 year ago

When uncommenting line 1068 you have to add a comma at the end of line 1067. Then it should work fine.

sharpwg1337 commented 1 year ago

When uncommenting line 1068 you have to add a comma at the end of line 1067. Then it should work fine.

OK, now it looks like this:

local ignoreInventorySlots = {
    [INVSLOT_BODY] = true, -- shirt
    [INVSLOT_TABARD] = true -- tabard,
    [INVSLOT_RANGED] = true -- ranged
};

comma on line 1067 (1068 is the ranged line) but still not doing anything

frozn commented 1 year ago

I meant this (after "true", end of statement before comment):

local ignoreInventorySlots = {
    [INVSLOT_BODY] = true, -- shirt
    [INVSLOT_TABARD] = true, -- tabard
    [INVSLOT_RANGED] = true -- ranged
};
frozn commented 1 year ago

Fixed with release v23.01.23.